Upgrade from Webpacker 3 to Shakapacker 7 and React-Rails 3 #1
Conversation
ahangarha
changed the title
|
@Judahmeek can review and merge. |
|
@Judahmeek I am wondering why those duplicate lines were added. Since it was a long time since I started working on this PR, I don't remember what I was doing then. We get some deprecation warnings in the terminal, and I believe it is because this project uses Rails 5. Do you think it should be fixed in this PR, or can it have another PR? |
| # Bundle edge Rails instead: gem 'rails', github: 'rails/rails' | ||
| gem 'rails', '~> 5.1.4' | ||
| gem "rails", "~> 5.2" |
There was a problem hiding this comment.
All in one PR?
I thought Upgrading Rails could and should have its own PR. And this little change was to make it possible to build the project. I don't remember now but there was an issue with Rails < 5.2. I couldn't run the app.
| exec "yarnpkg #{ARGV.join(" ")}" | ||
| rescue Errno::ENOENT | ||
|
|
||
| APP_ROOT = File.expand_path("..", __dir__) |
There was a problem hiding this comment.
why is this file not deleted?
There was a problem hiding this comment.
Even in Shakapacker, we still have this file.
ahangarha
changed the title
This PR upgrades the project as following:
We may keep the branch (maybe with a more appropriate name) like other branches in this project.